laravel框架代码优化!

Question

这一段代码还有没有其他的写法?这是我一个朋友写的帮他问问,谢谢!!

Answer 1

$mobileid = $req -> input('mobileid'); // 前台Ajax传递过来的参数
if($mobileid >= 1 && $mobileid <= 11){  
     $data = DB::table('sell_mobile')->where('mobileid',$mobileid)->select('pid','name','price','imgs')->get();  // 查询数据库
     
}

Answer 2

1 写法1和楼上一样

$brands_id = [1,2,3,4,5,6,7,8,9,10,11];
if(!in_array($brandid,$brands_id)){
    // id 不合法
    return ;
}
$data = DB::table('sell_index')->where('brandid',$brandid);

2 写法2

$brands_id = [1,2,3,4,5,6,7,8,9,10,11];
if(!in_array($brandid,$brands_id)){
    // id 不合法
    return ;
}
switch($brands_id){
    case 1:
    case 2:
    case 3:
    case 4:
    case 5:
    case 6:
    case 7:
    case 8:
    case 9:
    case 10:
    case 11:
        $data = DB::table('sell_index')->where('brandid',$brandid);//....
        break;
   
}

3写法3

if (is_int($brandid)&&$brandid>=1&&brandid<=11){
    $data = DB::table('sell_index')->where('brandid',$brandid);
}

Answer 3

$brands_id = [1,2,3,4,5,6,7,8,9,10,11];
if(!in_array($brandid,$brands_id)){
    // id 不合法
    return ;
}
$data = DB::table('sell_index')->where('brandid',$brandid);//....